Skip to content

Make Serving service mesh tests more stable#2196

Merged
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom
ReToCode:fix-graceful-serving
Jul 26, 2023
Merged

Make Serving service mesh tests more stable#2196
openshift-merge-robot merged 1 commit intoopenshift-knative:mainfrom
ReToCode:fix-graceful-serving

Conversation

@ReToCode
Copy link
Copy Markdown
Contributor

@ReToCode ReToCode commented Jul 26, 2023 •
edited
Loading

Fixes JIRA https://issues.redhat.com/browse/SRVCOM-2356
Partially fixes JIRA https://issues.redhat.com/browse/SRVKS-1099
Partially fixes JIRA https://issues.redhat.com/browse/SRVCOM-2522

Proposed Changes

We are trying to do #2171 in parts now. This PR contains the fixes found in https://issues.redhat.com/browse/SRVKS-1099 to make Serving service-mesh tests more stable

Changes:

  • Reduce parallelism of mesh tests to 8 because istio-proxies are to slow otherwise
  • Use a specific label for the Knative Gateways to omit issues with conflicting gateways (SRVCOM-2356)
  • Drop TERMINATION_DRAIN_DURATION_SECONDS from metadata-webhook, as this no longer works
  • Add terminationDrainDuration: 35s to SMCP to make envoy wait longer with termination

/cc @mgencur , @pierDipi

@openshift-ci openshift-ci bot requested review from jcrossley3 and mgencur July 26, 2023 09:39
@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Jul 26, 2023

/test 4.13-upstream-e2e-mesh-aws-ocp-413

@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Jul 26, 2023

/test 4.10-upstream-e2e-mesh-aws-ocp-410

@ReToCode ReToCode mentioned this pull request Jul 26, 2023
Closed
pierDipi
pierDipi approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 26, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jul 26, 2023

/hold for tests

@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Jul 26, 2023

/test 4.10-upstream-e2e-mesh-aws-ocp-410

1 similar comment
@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Jul 26, 2023

/test 4.10-upstream-e2e-mesh-aws-ocp-410

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jul 26, 2023

/unhold

Eventing failures are flakes

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Jul 26, 2023 •
edited
Loading

I think we might need to increase the timeout for the tests here
Same as we did here: here

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jul 26, 2023

I think we might need to increase the timeout for the tests here Same as we did here: here

Thanks!

@ReToCode
Copy link
Copy Markdown
Contributor Author

ReToCode commented Jul 26, 2023

👍 I'll add that then, but after 4.13-upstream-e2e-mesh-aws-ocp-413 is hopefully green once :)

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 26, 2023

@ReToCode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-upstream-e2e-mesh-aws-ocp-410 74b48c8 link false /test 4.10-upstream-e2e-mesh-aws-ocp-410
ci/prow/4.13-upstream-e2e-mesh-aws-ocp-413 74b48c8 link false /test 4.13-upstream-e2e-mesh-aws-ocp-413

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 92226e1 into openshift-knative:main Jul 26, 2023
@pierDipi pierDipi mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@pierDipi pierDipi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ReToCode @pierDipi @mgencur @openshift-merge-robot